[PATCH v2 1/2] drm/i915/gvt: Fix possible recursive locking issue

Dong, Chuanxiao chuanxiao.dong at intel.com
Mon Jun 26 07:22:58 UTC 2017



> -----Original Message-----
> From: intel-gvt-dev [mailto:intel-gvt-dev-bounces at lists.freedesktop.org] On
> Behalf Of Zhenyu Wang
> Sent: Saturday, June 24, 2017 8:16 PM
> To: Dong, Chuanxiao <chuanxiao.dong at intel.com>
> Cc: intel-gvt-dev at lists.freedesktop.org
> Subject: Re: [PATCH v2 1/2] drm/i915/gvt: Fix possible recursive locking issue
> 
> On 2017.06.23 10:32:48 +0000, Dong, Chuanxiao wrote:
> >
> > There will be a corner case when check list_empty(unpin_list) for
> scheduling the unpin_work. If there is no gfn marked removed in this notifier
> but the unpin_list is not empty which is doing the unpin, notifier will schedule
> the unpin_work again. Looks like using the check list_empty() can involve
> unnecessary scheduling of unpin_work. What do you think?
> >
> 
> yeah, good point and that has its own sync issue, so agree for your current
> version.
> 
Thanks Zhenyu.

Will send out v3 for the function name change comment and cc stable kernel.

Thanks
Chuanxiao

> --
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827


More information about the intel-gvt-dev mailing list