[PATCH 2/2] drm/i915/gvt: use pfn_valid for better checking

[Zhenyu Wang]

On 2017.02.24 10:03:11 +0800, Chuanxiao Dong wrote:
> Before get the page from pfn, use pfn_valid to check if pfn
> is able to translate to page structure.
> 
> Signed-off-by: Chuanxiao Dong <chuanxiao.dong at intel.com>
> ---

pls refresh to recent gvt-staging and resend.

>  drivers/gpu/drm/i915/gvt/kvmgt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index 4b5e88b..d12fc0d 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -96,10 +96,10 @@ static int gvt_dma_map_iova(struct intel_vgpu *vgpu, kvm_pfn_t pfn,
>  	struct device *dev = &vgpu->gvt->dev_priv->drm.pdev->dev;
>  	dma_addr_t daddr;
>  
> -	page = pfn_to_page(pfn);
> -	if (is_error_page(page))
> +	if (unlikely(!pfn_valid(pfn)))
>  		return -EFAULT;
>  
> +	page = pfn_to_page(pfn);
>  	daddr = dma_map_page(dev, page, 0, PAGE_SIZE,
>  			DMA_BIDIRECTIONAL);
>  	if (dma_mapping_error(dev, daddr))
> -- 
> 2.7.4
> 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20170301/7336f408/attachment.sig>