[PATCH v3] drm/i915/gvt: replace the gvt_err with gvt_vgpu_err

[Zhenyu Wang]

On 2017.03.05 20:11:02 -0500, Tina Zhang wrote:
> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index 7a5d7f5..947a20d 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -668,7 +668,7 @@ static inline void print_opcode(u32 cmd, int ring_id)
>  	if (d_info == NULL)
>  		return;
>  
> -	gvt_err("opcode=0x%x %s sub_ops:",
> +	gvt_dbg_cmd("opcode=0x%x %s sub_ops:",
>  			cmd >> (32 - d_info->op_len), d_info->name);
>  
>  	for (i = 0; i < d_info->nr_sub_op; i++)
> @@ -693,23 +693,23 @@ static void parser_exec_state_dump(struct parser_exec_state *s)
>  	int cnt = 0;
>  	int i;
>  
> -	gvt_err("  vgpu%d RING%d: ring_start(%08lx) ring_end(%08lx)"
> +	gvt_dbg_cmd("  vgpu%d RING%d: ring_start(%08lx) ring_end(%08lx)"
>  			" ring_head(%08lx) ring_tail(%08lx)\n", s->vgpu->id,
>  			s->ring_id, s->ring_start, s->ring_start + s->ring_size,
>  			s->ring_head, s->ring_tail);
>  
> -	gvt_err("  %s %s ip_gma(%08lx) ",
> +	gvt_dbg_cmd("  %s %s ip_gma(%08lx) ",
>  			s->buf_type == RING_BUFFER_INSTRUCTION ?
>  			"RING_BUFFER" : "BATCH_BUFFER",
>  			s->buf_addr_type == GTT_BUFFER ?
>  			"GTT" : "PPGTT", s->ip_gma);
>  
>  	if (s->ip_va == NULL) {
> -		gvt_err(" ip_va(NULL)");
> +		gvt_dbg_cmd(" ip_va(NULL)");
>  		return;
>  	}
>  
> -	gvt_err("  ip_va=%p: %08x %08x %08x %08x\n",
> +	gvt_dbg_cmd("  ip_va=%p: %08x %08x %08x %08x\n",
>  			s->ip_va, cmd_val(s, 0), cmd_val(s, 1),
>  			cmd_val(s, 2), cmd_val(s, 3));
>

These not for gvt_vgpu_err() conversion should be in another patch.

> diff --git a/drivers/gpu/drm/i915/gvt/debug.h b/drivers/gpu/drm/i915/gvt/debug.h
> index 68cba7b..2994f8e 100644
> --- a/drivers/gpu/drm/i915/gvt/debug.h
> +++ b/drivers/gpu/drm/i915/gvt/debug.h
> @@ -27,6 +27,9 @@
>  #define gvt_err(fmt, args...) \
>  	DRM_ERROR("gvt: "fmt, ##args)
>  
> +#define gvt_vgpu_err(fmt, args...) \
> +	DRM_DEBUG_DRIVER("gvt: vgpu %d: "fmt, vgpu->id, ##args)
> +

As this is vgpu err even if like to put under some debug level, could we put
some ERROR tag for this? Otherwise why not just convert to gvt_dbg_xxx?

>  #define gvt_dbg_core(fmt, args...) \
>  	DRM_DEBUG_DRIVER("gvt: core: "fmt, ##args)
>  
-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20170306/0fb877c7/attachment.sig>