[PATCH] drm/i915/gvt: remove the redundant info NULL check

Zhenyu Wang zhenyuw at linux.intel.com
Tue Mar 28 03:22:41 UTC 2017


On 2017.03.24 09:14:21 +0000, Zhang, Tina wrote:
> Add Colin and Dan.
> Thanks.
> 
> > -----Original Message-----
> > From: intel-gvt-dev [mailto:intel-gvt-dev-bounces at lists.freedesktop.org] On
> > Behalf Of Tina Zhang
> > Sent: Friday, March 24, 2017 1:57 PM
> > To: intel-gvt-dev at lists.freedesktop.org
> > Cc: Zhang, Tina <tina.zhang at intel.com>
> > Subject: [PATCH] drm/i915/gvt: remove the redundant info NULL check
> > 
> > The variable info is never NULL, which is checked by the caller. This patch
> > removes the redundant info NULL check logic.
> > 
> > Signed-off-by: Tina Zhang <tina.zhang at intel.com>
> > 
> > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c
> > b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > index d641214..2d92119 100644
> > --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> > +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > @@ -1340,13 +1340,6 @@ static int kvmgt_guest_init(struct mdev_device
> > *mdev)
> > 
> >  static bool kvmgt_guest_exit(struct kvmgt_guest_info *info)  {
> > -	struct intel_vgpu *vgpu = info->vgpu;
> > -
> > -	if (!info) {
> > -		gvt_vgpu_err("kvmgt_guest_info invalid\n");
> > -		return false;
> > -	}
> > -
> >  	kvm_page_track_unregister_notifier(info->kvm, &info->track_node);
> >  	kvm_put_kvm(info->kvm);
> >  	kvmgt_protect_table_destroy(info);
> > --

queued this on -fixes, pls add proper Fixes: line next time (I added this time).

thanks!

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20170328/aad4bd20/attachment.sig>


More information about the intel-gvt-dev mailing list