[PATCH] i915/gvt/handlers.c: Dup definition of MMIO 0x22040 on BDW+

[Zhenyu Wang]

On 2017.05.05 07:39:57 +0000, Zhang, Xiong Y wrote:
> > On Sat, May 06, 2017 at 07:33:37AM +0800, Xiong Zhang wrote:
> > > MMIO 0x22040 is Blitter/Render Semaphore Sync Register which has
> > > defined through MMIO_RING_DFH(RING_SYNC_0) in
> > > init_generic_mmio_info(), but init_broadwell_mmio_info() defines
> > > this MMIO again through MMIO_D(0x22040, D_BDW_PLUS),
> > MMIO_D(0x22040)
> > > remove F_CMD_ACCESS flag. This generate error caution in dmesg.
> > >
> > > Signed-off-by: Xiong Zhang <xiong.y.zhang at intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/gvt/handlers.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/gvt/handlers.c
> > b/drivers/gpu/drm/i915/gvt/handlers.c
> > > index 6da9ae1..72ecb62 100644
> > > --- a/drivers/gpu/drm/i915/gvt/handlers.c
> > > +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> > > @@ -2545,7 +2545,6 @@ static int init_broadwell_mmio_info(struct
> > intel_gvt *gvt)
> > >  	MMIO_F(0x24d0, 48, F_CMD_ACCESS, 0, 0, D_BDW_PLUS,
> > >  		NULL, force_nonpriv_write);
> > >
> > > -	MMIO_D(0x22040, D_BDW_PLUS);
> > There are 5 more dups, maybe remove them once?
> > [    6.715148] [drm:new_mmio_info [i915]] *ERROR* gvt: dup mmio
> > definition offset 22040
> > [    6.715351] [drm:new_mmio_info [i915]] *ERROR* gvt: dup mmio
> > definition offset 138124
> > [    6.733030] [drm:new_mmio_info [i915]] *ERROR* gvt: dup mmio
> > definition offset 1a028
> > [    6.733100] [drm:new_mmio_info [i915]] *ERROR* gvt: dup mmio
> > definition offset 940c
> > [    6.733123] [drm:new_mmio_info [i915]] *ERROR* gvt: dup mmio
> > definition offset 4ab0
> > [    6.733142] [drm:new_mmio_info [i915]] *ERROR* gvt: dup
> > mmiodefinition offset 20d4
> > 
> [Zhang, Xiong Y] I just see one with 4.11 kernel, maybe more are
> in staging branch.
> 

Might be introduced by KBL change. Maybe we should check handler
reference further, simple dup should be just warning, but handler
difference should be a serious error.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20170508/d8893abb/attachment.sig>