[PATCH 7/9] drm/i915/gvt: Rename reserved ring buffer

Zhenyu Wang zhenyuw at linux.intel.com
Mon Sep 11 06:53:46 UTC 2017


On 2017.09.11 12:44:11 +0800, Zhi Wang wrote:
> "reserved" means reserve something from somewhere. Actually they are
> buffers used by command scanner. Rename it to ring_scan_buffer.
> 
> Signed-off-by: Zhi Wang <zhi.a.wang at intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/cmd_parser.c | 16 ++++++++--------
>  drivers/gpu/drm/i915/gvt/execlist.c   | 22 +++++++++++-----------
>  drivers/gpu/drm/i915/gvt/gvt.h        |  6 +++---
>  3 files changed, 22 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index 22d33be..0f8d988 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -2619,21 +2619,21 @@ static int shadow_workload_ring_buffer(struct intel_vgpu_workload *workload)
>  	gma_tail = workload->rb_start + workload->rb_tail;
>  	gma_top = workload->rb_start + guest_rb_size;
>  
> -	if (workload->rb_len > vgpu->reserve_ring_buffer_size[ring_id]) {
> -		void *va, *p;
> +	if (workload->rb_len > vgpu->ring_scan_buffer_size[ring_id]) {
> +		void *buffer, *p;
>  
>  		/* realloc the new ring buffer if needed */
> -		va = vgpu->reserve_ring_buffer_va[ring_id];
> -		p = krealloc(va, workload->rb_len, GFP_KERNEL);
> +		buffer = vgpu->ring_scan_buffer[ring_id];
> +		p = krealloc(buffer, workload->rb_len, GFP_KERNEL);
>  		if (!p) {
> -			gvt_vgpu_err("fail to alloc reserve ring buffer\n");
> +			gvt_vgpu_err("fail to re-alloc ring scan buffer\n");
>  			return -ENOMEM;
>  		}
> -		vgpu->reserve_ring_buffer_va[ring_id] = p;
> -		vgpu->reserve_ring_buffer_size[ring_id] = workload->rb_len;
> +		vgpu->ring_scan_buffer[ring_id] = p;
> +		vgpu->ring_scan_buffer_size[ring_id] = workload->rb_len;
>  	}

Remove extra *buffer then this cleanup series looks fine to me.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20170911/3b62808d/attachment.sig>


More information about the intel-gvt-dev mailing list