[PATCH] drm/i915/gvt: Handle GEN9_WM_CHICKEN3 with F_CMD_ACCESS for BXT.

Zhenyu Wang zhenyuw at linux.intel.com
Thu Aug 16 06:49:17 UTC 2018


On 2018.08.16 12:25:28 +0800, Colin Xu wrote:
> Recent patch introduce strict check on scanning cmd:
> Commit 8d458ea0ec33 ("drm/i915/gvt: return error on cmd access")
> 
> On BXT, i915 applies WaClearHIZ_WM_CHICKEN3 which will program
> the reg 0x5588 by LRI, so we should handle GEN9_WM_CHICKEN3 with
> F_CMD_ACCESS, also add F_MODE_MASK since it's mode mask reg.
>

Could you elaborate more on the symptom that this one fixes? As
we have more strict cmd scan detection, does this cause guest failure or etc.?

> Signed-off-by: Colin Xu <colin.xu at intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/handlers.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
> index cf2a4020949d..e32a69fabda3 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -3205,6 +3205,8 @@ static int init_bxt_mmio_info(struct intel_gvt *gvt)
>  	MMIO_D(GEN8_L3SQCREG1, D_BXT);
>  
>  	MMIO_DFH(GEN9_CTX_PREEMPT_REG, D_BXT, F_CMD_ACCESS, NULL, NULL);
> +	MMIO_DFH(GEN9_WM_CHICKEN3, D_BXT,
> +		 F_MODE_MASK | F_CMD_ACCESS, NULL, NULL);
>  
>  	return 0;
>  }
> -- 
> 2.18.0
> 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20180816/29422323/attachment.sig>


More information about the intel-gvt-dev mailing list