[PATCH] drm/i915: add schedule out notification of completed request during unwind

[Li, Weinan Z]

-----Original Message-----
From: Chris Wilson [mailto:chris at chris-wilson.co.uk] 
Sent: Thursday, February 8, 2018 3:37 PM
To: Li, Weinan Z <weinan.z.li at intel.com>; intel-gfx at lists.freedesktop.org
Cc: intel-gvt-dev at lists.freedesktop.org; Li, Weinan Z <weinan.z.li at intel.com>; Zhenyu Wang <zhenyuw at linux.intel.com>
Subject: Re: [PATCH] drm/i915: add schedule out notification of completed request during unwind

Quoting Weinan Li (2018-02-08 01:17:59)
> There is one corner case missing schedule out notification for GVT-g 
> in __unwind_incomplete_requests, it may cause vgpu no response. Add 
> notification when ensure one request has been completed during doing 
> unwind.

You never get the schedule-in for those, only ELSP.
-Chris

@@ -285,9 +314,10 @@ static void __unwind_incomplete_requests(struct intel_engine_cs *engine)
 	list_for_each_entry_safe_reverse(rq, rn,
 					 &engine->timeline->requests,
 					 link) {
-		if (i915_gem_request_completed(rq))
+		if (i915_gem_request_completed(rq)) {
Thanks Chris, Do you mean it won't run to here, I am not sure but I indeed found notification missing in GVT-g with linux guest.
+			execlists_context_schedule_out(rq);
 			return;
-
+		}