[RfC PATCH v3 5/5] vfio/display: adding region support

Gerd Hoffmann kraxel at redhat.com
Fri Feb 16 14:01:18 UTC 2018


> > +static int vfio_display_region_init(VFIOPCIDevice *vdev, Error **errp)
> > +{
> > +    vdev->dpy = g_new0(VFIODisplay, 1);
> > +    vdev->dpy->con = graphic_console_init(DEVICE(vdev), 0,
> > +                                          &vfio_display_region_ops,
> > +                                          vdev);
> > +    /* TODO: disable hotplug (there is no graphic_console_close) */
> 
> via DeviceClass.hotpluggable?  I know that QE will immediately test
> this, so it needs to be sorted out sooner than later.

Hmm, I think setting DeviceClass.hotpluggable would tag all vfio devices
as not hotpluggable, not only the one we just created a display for.

cheers,
  Gerd



More information about the intel-gvt-dev mailing list