[PATCH 2/2] drm/i915/gvt: Return error at the failure of finding page_track

[Zhenyu Wang]

On 2018.03.06 06:07:28 +0800, Xiong Zhang wrote:
> In XenGT, ioreq copy is used to trap mmio write and ppgtt write. Both
> of them are memory write, ioreq handler couldn't distinguish them. So
> ioreq handler probe the ppgtt write handler, if it is succuess, this
> ioreq is ppgtt write, otherwise it is mmio write.
> 
> So ppgtt write handler should return an error at the failure of finding
> page track, it is fatal to implement ioreq handler in XenGT.
> 
> Signed-off-by: Xiong Zhang <xiong.y.zhang at intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/page_track.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/page_track.c b/drivers/gpu/drm/i915/gvt/page_track.c
> index 2d03054..53e2bd7 100644
> --- a/drivers/gpu/drm/i915/gvt/page_track.c
> +++ b/drivers/gpu/drm/i915/gvt/page_track.c
> @@ -164,8 +164,10 @@ int intel_vgpu_page_track_handler(struct intel_vgpu *vgpu, u64 gpa,
>  	mutex_lock(&gvt->lock);
>  
>  	page_track = intel_vgpu_find_page_track(vgpu, gpa >> PAGE_SHIFT);
> -	if (!page_track)
> +	if (!page_track) {
> +		ret = -ENXIO;
>  		goto out;
> +	}
>  
>  	if (unlikely(vgpu->failsafe)) {
>  		/* Remove write protection to prevent furture traps. */
> -- 

Reasonable to keep original return design. Applied, thanks!

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20180305/3f439f00/attachment.sig>