[PATCH] drm/i915/gvt: Add GEN9_CLKGATE_DIS_4 to default BXT mmio handler

He, Min min.he at intel.com
Fri Sep 14 09:29:29 UTC 2018


Nice catch. Thanks.
Reviewed-by: He, Min <min.he at intel.com>

> -----Original Message-----
> From: intel-gvt-dev [mailto:intel-gvt-dev-bounces at lists.freedesktop.org] On
> Behalf Of Colin Xu
> Sent: Friday, September 14, 2018 3:12 PM
> To: intel-gvt-dev at lists.freedesktop.org
> Cc: Xu, Colin <colin.xu at intel.com>
> Subject: [PATCH] drm/i915/gvt: Add GEN9_CLKGATE_DIS_4 to default BXT
> mmio handler
> 
> Host prints lots of untracked MMIO at 0x4653c when creating linux guest.
> "gvt: vgpu 2: untracked MMIO 0004653c len 4"
> 
> GEN9_CLKGATE_DIS_4 (0x4653c) is accessed by i915 for gmbus clockgating.
> However vgpu doesn't support any clockgating powergating operations on
> related mmio access trap so need add it to default handler.
> GEN9_CLKGATE_DIS_4 is accessed in bxt_gmbus_clock_gating() which only
> applies to GEN9_LP so doens't show the warning on other platforms.
> 
> The solution is to add it to default handler init_bxt_mmio_info().
> 
> Signed-off-by: Colin Xu <colin.xu at intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/handlers.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c
> b/drivers/gpu/drm/i915/gvt/handlers.c
> index ea91285a5e1c..90f50f67909a 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -3199,6 +3199,7 @@ static int init_bxt_mmio_info(struct intel_gvt *gvt)
>  	MMIO_D(BXT_DSI_PLL_ENABLE, D_BXT);
> 
>  	MMIO_D(GEN9_CLKGATE_DIS_0, D_BXT);
> +	MMIO_D(GEN9_CLKGATE_DIS_4, D_BXT);
> 
>  	MMIO_D(HSW_TVIDEO_DIP_GCP(TRANSCODER_A), D_BXT);
>  	MMIO_D(HSW_TVIDEO_DIP_GCP(TRANSCODER_B), D_BXT);
> --
> 2.19.0
> 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev


More information about the intel-gvt-dev mailing list