[PATCH v3 0/6] Fix issues reported by klocwork

Aleksei Gimbitskii aleksei.gimbitskii at intel.com
Tue Apr 23 12:04:07 UTC 2019


The klocwork static code analyzer found 11 critical issues and 7 error
issues in GVT-g source code. After the analyzation, one critical issue
and 6 "errors" was concluded as harmless. This patchset fixes other
cases, which might cause potential issues in future.

v3:
- Remove typedef and let the enumeration starts from zero.

V2:
- Print some error messages if page table type is invalid. (Colin Xu)
- Increase the size of the buffer. (Colin Xu)
- Initialize fb_info.obj in vgpu_get_plane_info(). (Colin Xu)

Aleksei Gimbitskii (6):
  drm/i915/gvt: Remove typedef and let the enumeration starts from zero
  drm/i915/gvt: Do not copy the uninitialized pointer from fb_info
  drm/i915/gvt: Use snprintf() to prevent possible buffer overflow.
  drm/i915/gvt: Check if cur_pt_type is valid
  drm/i915/gvt: Assign NULL to the pointer after memory free.
  drm/i915/gvt: Check if get_next_pt_type() always returns a valid value

 drivers/gpu/drm/i915/gvt/debugfs.c   |  4 ++--
 drivers/gpu/drm/i915/gvt/dmabuf.c    |  2 ++
 drivers/gpu/drm/i915/gvt/gtt.c       | 27 ++++++++++++++++++++-------
 drivers/gpu/drm/i915/gvt/gtt.h       | 16 ++++++++--------
 drivers/gpu/drm/i915/gvt/handlers.c  |  2 +-
 drivers/gpu/drm/i915/gvt/scheduler.c |  2 +-
 6 files changed, 34 insertions(+), 19 deletions(-)

-- 
2.17.1

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



More information about the intel-gvt-dev mailing list