[PATCH] drm/i915/gvt: Remove logging when checking surface base address

[Zhang, Xiaolin]

On 04/24/2019 09:39 AM, Zhang, Tina wrote:
> The vgpu's plane surface base address register could contain invalidated
> values. Only validated values can be used by GVT-g display model.
> Invalidated values should be ignored w/o causing any noise.
>
> Cc: Xiaolin Zhang <xiaolin.zhang at intel.com>
> Signed-off-by: Tina Zhang <tina.zhang at intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/fb_decoder.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/fb_decoder.c b/drivers/gpu/drm/i915/gvt/fb_decoder.c
> index 65e8473..3564bc4 100644
> --- a/drivers/gpu/drm/i915/gvt/fb_decoder.c
> +++ b/drivers/gpu/drm/i915/gvt/fb_decoder.c
> @@ -245,7 +245,7 @@ int intel_vgpu_decode_primary_plane(struct intel_vgpu *vgpu,
>  	plane->hw_format = fmt;
>  
>  	plane->base = vgpu_vreg_t(vgpu, DSPSURF(pipe)) & I915_GTT_PAGE_MASK;
> -	if (!intel_gvt_ggtt_validate_range(vgpu, plane->base, 0))
> +	if (!plane->base || !vgpu_gmadr_is_valid(vgpu, plane->base))
>  		return  -EINVAL;
I think we still fire error message in second check for non zero base
case to indicate there is something wrong.
>
>  	plane->base_gpa = intel_vgpu_gma_to_gpa(vgpu->gtt.ggtt_mm, plane->base);
> @@ -368,7 +368,7 @@ int intel_vgpu_decode_cursor_plane(struct intel_vgpu *vgpu,
>  			alpha_plane, alpha_force);
>  
>  	plane->base = vgpu_vreg_t(vgpu, CURBASE(pipe)) & I915_GTT_PAGE_MASK;
> -	if (!intel_gvt_ggtt_validate_range(vgpu, plane->base, 0))
> +	if (!plane->base || !vgpu_gmadr_is_valid(vgpu, plane->base))
>  		return  -EINVAL;
>  
>  	plane->base_gpa = intel_vgpu_gma_to_gpa(vgpu->gtt.ggtt_mm, plane->base);
> @@ -472,7 +472,7 @@ int intel_vgpu_decode_sprite_plane(struct intel_vgpu *vgpu,
>  	plane->drm_format = drm_format;
>  
>  	plane->base = vgpu_vreg_t(vgpu, SPRSURF(pipe)) & I915_GTT_PAGE_MASK;
> -	if (!intel_gvt_ggtt_validate_range(vgpu, plane->base, 0))
> +	if (!plane->base || !vgpu_gmadr_is_valid(vgpu, plane->base))
>  		return  -EINVAL;
>  
>  	plane->base_gpa = intel_vgpu_gma_to_gpa(vgpu->gtt.ggtt_mm, plane->base);