[PATCH v3 0/6] Fix issues reported by klocwork

Zhenyu Wang zhenyuw at linux.intel.com
Thu Apr 25 07:47:28 UTC 2019


On 2019.04.23 15:04:07 +0300, Aleksei Gimbitskii wrote:
> The klocwork static code analyzer found 11 critical issues and 7 error
> issues in GVT-g source code. After the analyzation, one critical issue
> and 6 "errors" was concluded as harmless. This patchset fixes other
> cases, which might cause potential issues in future.
> 
> v3:
> - Remove typedef and let the enumeration starts from zero.
> 
> V2:
> - Print some error messages if page table type is invalid. (Colin Xu)
> - Increase the size of the buffer. (Colin Xu)
> - Initialize fb_info.obj in vgpu_get_plane_info(). (Colin Xu)
> 
> Aleksei Gimbitskii (6):
>   drm/i915/gvt: Remove typedef and let the enumeration starts from zero
>   drm/i915/gvt: Do not copy the uninitialized pointer from fb_info
>   drm/i915/gvt: Use snprintf() to prevent possible buffer overflow.
>   drm/i915/gvt: Check if cur_pt_type is valid
>   drm/i915/gvt: Assign NULL to the pointer after memory free.
>   drm/i915/gvt: Check if get_next_pt_type() always returns a valid value
> 
>  drivers/gpu/drm/i915/gvt/debugfs.c   |  4 ++--
>  drivers/gpu/drm/i915/gvt/dmabuf.c    |  2 ++
>  drivers/gpu/drm/i915/gvt/gtt.c       | 27 ++++++++++++++++++++-------
>  drivers/gpu/drm/i915/gvt/gtt.h       | 16 ++++++++--------
>  drivers/gpu/drm/i915/gvt/handlers.c  |  2 +-
>  drivers/gpu/drm/i915/gvt/scheduler.c |  2 +-
>  6 files changed, 34 insertions(+), 19 deletions(-)
> 

I have applied most of these except patch 4, 5 which looks still
need some polish.

thanks

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20190425/2120528b/attachment.sig>


More information about the intel-gvt-dev mailing list