[PATCH 2/3] drm/i915/gvt: use vgpu lock for active state setting

Colin Xu Colin.Xu at intel.com
Wed Dec 4 02:58:15 UTC 2019


Yes here should use vgpu_lock instead of gvt->lock.
Made this wrong in initial submit. Thanks for catching out.

Reviewed-by: Colin Xu <colin.xu at intel.com>

On 2019-12-02 15:01, Zhenyu Wang wrote:
> Need to align with deactivate, should only use vgpu's lock for
> active state setting instead of gvt lock.
>
> Fixes: f25a49ab8ab9 ("drm/i915/gvt: Use vgpu_lock to protect per vgpu access")
> Cc: Colin Xu <colin.xu at intel.com>
> Signed-off-by: Zhenyu Wang <zhenyuw at linux.intel.com>
> ---
>   drivers/gpu/drm/i915/gvt/vgpu.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c
> index d5a6e4e3d0fd..85bd9bf4f6ee 100644
> --- a/drivers/gpu/drm/i915/gvt/vgpu.c
> +++ b/drivers/gpu/drm/i915/gvt/vgpu.c
> @@ -212,9 +212,9 @@ static void intel_gvt_update_vgpu_types(struct intel_gvt *gvt)
>    */
>   void intel_gvt_activate_vgpu(struct intel_vgpu *vgpu)
>   {
> -	mutex_lock(&vgpu->gvt->lock);
> +	mutex_lock(&vgpu->vgpu_lock);
>   	vgpu->active = true;
> -	mutex_unlock(&vgpu->gvt->lock);
> +	mutex_unlock(&vgpu->vgpu_lock);
>   }
>   
>   /**

-- 
Best Regards,
Colin Xu



More information about the intel-gvt-dev mailing list