[PATCH 1/3] drm/i915/gvt: remove unused type attributes

Yan Zhao yan.y.zhao at intel.com
Wed Dec 4 06:35:08 UTC 2019


Reviewed-by: Yan Zhao <yan.y.zhao at intel.com>

On Mon, Dec 02, 2019 at 03:01:07PM +0800, Zhenyu Wang wrote:
> Only need to get attribute group instead of attributes and it has
> no use, so remove it.
> 
> Signed-off-by: Zhenyu Wang <zhenyuw at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/gvt.c   | 4 +---
>  drivers/gpu/drm/i915/gvt/gvt.h   | 3 +--
>  drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +---
>  3 files changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/gvt.c b/drivers/gpu/drm/i915/gvt/gvt.c
> index 8f37eefa0a02..cb5fa30b8e63 100644
> --- a/drivers/gpu/drm/i915/gvt/gvt.c
> +++ b/drivers/gpu/drm/i915/gvt/gvt.c
> @@ -120,10 +120,8 @@ static struct attribute_group *gvt_vgpu_type_groups[] = {
>  	[0 ... NR_MAX_INTEL_VGPU_TYPES - 1] = NULL,
>  };
>  
> -static bool intel_get_gvt_attrs(struct attribute ***type_attrs,
> -		struct attribute_group ***intel_vgpu_type_groups)
> +static bool intel_get_gvt_attrs(struct attribute_group ***intel_vgpu_type_groups)
>  {
> -	*type_attrs = gvt_type_attrs;
>  	*intel_vgpu_type_groups = gvt_vgpu_type_groups;
>  	return true;
>  }
> diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h
> index b47c6acaf9c0..0081b051d3e0 100644
> --- a/drivers/gpu/drm/i915/gvt/gvt.h
> +++ b/drivers/gpu/drm/i915/gvt/gvt.h
> @@ -570,8 +570,7 @@ struct intel_gvt_ops {
>  	void (*vgpu_deactivate)(struct intel_vgpu *);
>  	struct intel_vgpu_type *(*gvt_find_vgpu_type)(struct intel_gvt *gvt,
>  			const char *name);
> -	bool (*get_gvt_attrs)(struct attribute ***type_attrs,
> -			struct attribute_group ***intel_vgpu_type_groups);
> +	bool (*get_gvt_attrs)(struct attribute_group ***intel_vgpu_type_groups);
>  	int (*vgpu_query_plane)(struct intel_vgpu *vgpu, void *);
>  	int (*vgpu_get_dmabuf)(struct intel_vgpu *vgpu, unsigned int);
>  	int (*write_protect_handler)(struct intel_vgpu *, u64, void *,
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index 04a5a0d90823..a699ecade3fc 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -1597,12 +1597,10 @@ static struct mdev_parent_ops intel_vgpu_ops = {
>  
>  static int kvmgt_host_init(struct device *dev, void *gvt, const void *ops)
>  {
> -	struct attribute **kvm_type_attrs;
>  	struct attribute_group **kvm_vgpu_type_groups;
>  
>  	intel_gvt_ops = ops;
> -	if (!intel_gvt_ops->get_gvt_attrs(&kvm_type_attrs,
> -			&kvm_vgpu_type_groups))
> +	if (!intel_gvt_ops->get_gvt_attrs(&kvm_vgpu_type_groups))
>  		return -EFAULT;
>  	intel_vgpu_ops.supported_type_groups = kvm_vgpu_type_groups;
>  
> -- 
> 2.24.0
> 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev


More information about the intel-gvt-dev mailing list