[PATCH v1 1/3] drm/i915/gvt: Utility for valid command length check

[Gao, Fred]

Thanks .
 It is the LRI cmd in kernel  who is not matched with intel docs.
Will send the updated series later.

-----Original Message-----
From: Zhenyu Wang <zhenyuw at linux.intel.com> 
Sent: 2019年7月18日 13:42
To: Gao, Fred <fred.gao at intel.com>
Cc: intel-gvt-dev at lists.freedesktop.org
Subject: Re: [PATCH v1 1/3] drm/i915/gvt: Utility for valid command length check

On 2019.07.15 06:07:04 +0800, fred gao wrote:
> From: "Gao, Fred" <fred.gao at intel.com>
> 
> Add utility for valid command length check.
> 
> v2: Add F_VAL_CONST flag to identify the value is const
>     although LEN maybe variable. (Zhenyu)
> v3: unused code removal, flag rename/conflict. (Zhenyu)
> v4: redefine F_IP_ADVANCE_CUSTOM and move the check function to
>     next patch. (Zhenyu)
> 
> Signed-off-by: Gao, Fred <fred.gao at intel.com>
> ---

I just try to test this series as I haven't checked all definition correctness for these cmds. On latest gvt-staging for host/guest, I got below error that failed linux guest.

[  578.692201] vfio_mdev 59f41f94-a91e-11e9-bca5-77e06e0f5813: Adding to iommu group 0 [  578.692204] vfio_mdev 59f41f94-a91e-11e9-bca5-77e06e0f5813: MDEV: group_id = 0 [  602.103214] [drm:drm_mode_addfb2] [FB:104] [  603.301618] gvt: len is not valid:  len=19  valid_len=3 [  603.301621] gvt: vgpu 1: cmd parser error [  603.301622] 0x0 [  603.301622] 0x22 

[  603.301624] gvt: vgpu 1: scan workload error [  603.301625] GVT Internal error  for the guest [  603.301626] Now vgpu 1 will enter failsafe mode.
[  603.301627] gvt: vgpu 1: failed to submit desc 0 [  603.301628] gvt: vgpu 1: fail submit workload on ring 0 [  603.301629] gvt: vgpu 1: fail to emulate MMIO write 00002230 len 4

Pls verify this series against latest gvt-staging.

--
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827