[PATCH] drm/i915/gvt: Return -EINVAL when cmd parser access shadowed mmio

Colin Xu colin.xu at intel.com
Wed May 22 06:19:52 UTC 2019


cmd_reg_handler() doesn't allow access shadowed mmio but still returns 0.
Return -EINVAL instead so that caller can handle properly.

Fixes: be1da7070aea ("drm/i915/gvt: vGPU command scanner")

Signed-off-by: Colin Xu <colin.xu at intel.com>
---
 drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
index 5cb59c0b4bbe..c50ef205325c 100644
--- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
+++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
@@ -878,7 +878,7 @@ static int cmd_reg_handler(struct parser_exec_state *s,
 
 	if (is_shadowed_mmio(offset)) {
 		gvt_vgpu_err("found access of shadowed MMIO %x\n", offset);
-		return 0;
+		return -EINVAL;
 	}
 
 	if (is_mocs_mmio(offset) &&
-- 
2.21.0



More information about the intel-gvt-dev mailing list