[PATCH v2] drm/i915/gvt: Add set_ggtt_entry tracing event

[Zhang, Tina]

> -----Original Message-----
> From: Zhenyu Wang [mailto:zhenyuw at linux.intel.com]
> Sent: Thursday, May 23, 2019 10:46 AM
> To: Zhang, Tina <tina.zhang at intel.com>
> Cc: intel-gvt-dev at lists.freedesktop.org
> Subject: Re: [PATCH v2] drm/i915/gvt: Add set_ggtt_entry tracing event
> 
> On 2019.05.23 06:11:14 +0800, Tina Zhang wrote:
> > Add set_ggtt_entry tracing event.
> >
> > v2:
> > - Add index field. (Zhenyu)
> >
> > Signed-off-by: Tina Zhang <tina.zhang at intel.com>
> > ---
> >  drivers/gpu/drm/i915/gvt/gtt.c   |  1 +
> >  drivers/gpu/drm/i915/gvt/trace.h | 22 ++++++++++++++++++++++
> >  2 files changed, 23 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/gtt.c
> > b/drivers/gpu/drm/i915/gvt/gtt.c index c2f7d20f6346..15216c5b40aa
> > 100644
> > --- a/drivers/gpu/drm/i915/gvt/gtt.c
> > +++ b/drivers/gpu/drm/i915/gvt/gtt.c
> > @@ -629,6 +629,7 @@ static void ggtt_set_host_entry(struct
> intel_vgpu_mm *mm,
> >  	struct intel_gvt_gtt_pte_ops *pte_ops = mm->vgpu->gvt-
> >gtt.pte_ops;
> >
> >  	GEM_BUG_ON(mm->type != INTEL_GVT_MM_GGTT);
> > +	trace_set_ggtt_entry(mm->vgpu->id, entry->val64, index);
> >
> >  	pte_ops->set_entry(NULL, entry, index, false, 0, mm->vgpu);  } diff
> > --git a/drivers/gpu/drm/i915/gvt/trace.h
> > b/drivers/gpu/drm/i915/gvt/trace.h
> > index 6d787750d279..981cc36eb50f 100644
> > --- a/drivers/gpu/drm/i915/gvt/trace.h
> > +++ b/drivers/gpu/drm/i915/gvt/trace.h
> > @@ -373,6 +373,28 @@ TRACE_EVENT(render_mmio,
> >  		  __entry->old_val, __entry->new_val)  );
> >
> > +TRACE_EVENT(set_ggtt_entry,
> > +	TP_PROTO(int id, unsigned long address,
> > +		    unsigned long index),
> > +
> 
> Better stick with u64 for address type and use proper 0x%llx below for printk.
About type, do you mean ggtt or ppgtt? We only trace ggtt here. Thanks.

BR,
Tina
> 
> > +	TP_ARGS(id, address, index),
> > +
> > +	TP_STRUCT__entry(
> > +		__field(int, id)
> > +		__field(unsigned long, address)
> > +		__field(unsigned long, index)
> > +	),
> > +
> > +	TP_fast_assign(
> > +		__entry->id = id;
> > +		__entry->address = address;
> > +		__entry->index = index;
> > +	),
> > +
> > +	TP_printk("vgpu%d:set ggtt entry 0x%lx, index 0x%lx\n",
> > +		  __entry->id, __entry->address, __entry->index) );
> > +
> >  #endif /* _GVT_TRACE_H_ */
> >
> >  /* This part must be out of protection */
> > --
> > 2.17.1
> >
> 
> --
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827