[PATCH] drm/i915/gvt: remove duplicated return

Zhang, Tina tina.zhang at intel.com
Thu Nov 21 01:03:42 UTC 2019



> -----Original Message-----
> From: intel-gvt-dev <intel-gvt-dev-bounces at lists.freedesktop.org> On Behalf
> Of Liu Xinyun
> Sent: Tuesday, November 19, 2019 6:52 PM
> To: intel-gvt-dev at lists.freedesktop.org
> Subject: [PATCH] drm/i915/gvt: remove duplicated return
> 
> clean up unnecessary return case
> 
> Signed-off-by: Liu Xinyun <xinyun.liu at intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/gtt.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
> index 4b04af569c05..4352a410a4d0 100644
> --- a/drivers/gpu/drm/i915/gvt/gtt.c
> +++ b/drivers/gpu/drm/i915/gvt/gtt.c
> @@ -788,8 +788,7 @@ static int ppgtt_write_protection_handler(
>  		return -EINVAL;
> 
>  	ret = ppgtt_handle_guest_write_page_table_bytes(spt, gpa, data,
> bytes);
> -	if (ret)
> -		return ret;
> +
>  	return ret;
Then, we don't need "ret" in this function any more. Better be "return ppgtt_handle_guest_write_page_table_bytes(" instead of using ret as the "middle man".
Thanks.


BR,
Tina 

>  }
> 
> --
> 2.17.1
> 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev


More information about the intel-gvt-dev mailing list