[PATCH 01/10] drm/i915/gvt: parse init context to update cmd accessible reg whitelist

Yan Zhao yan.y.zhao at intel.com
Tue Dec 1 06:13:37 UTC 2020


<...> 
> > > > +
> > > > +	if (intel_gt_wait_for_idle(&dev_priv->gt,
> > > > +				I915_GEM_IDLE_TIMEOUT) == -ETIME) {
> > > > +		ret = -EIO;
> > > > +		goto out;
> > > > +	}
> > > > +
> > > > +	for_each_engine(engine, &dev_priv->gt, id) {
> > > > +		struct i915_request *rq;
> > > > +
> > > > +		rq = requests[id];
> > > > +		GEM_BUG_ON(!i915_request_completed(rq));
> > > > +		GEM_BUG_ON(!intel_context_is_pinned(rq->context));
> > > > +		ctx_obj[id] = rq->context->state->obj;
> > > > +	}
> > > > +
> > > 
> > > and these two iterations?
> > This iteration cannot be combined with previous one because there's only
> > one intel_gt_wait_for_idle for all rings.
> >
> 
> yeah, I mean above this and below which handles for each engine's ctx,
> should be in one, right?
> 
yes, I'll try to merge them.

Thanks for spotting it :)


Yan


More information about the intel-gvt-dev mailing list