[PATCH 05/10] drm/i915/gvt: filter cmd "pipe-ctrl" in cmd_handler

[Zhenyu Wang]

On 2020.11.25 08:39:43 +0800, Yan Zhao wrote:
> "pipe-ctrl" is still a TODO. allow it here.
> 
> Cc: Colin Xu <colin.xu at intel.com>
> Cc: Kevin Tian <kevin.tian at intel.com>
> Signed-off-by: Yan Zhao <yan.y.zhao at intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/cmd_parser.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index f898c8b2064d..e9013b9f3344 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -997,6 +997,11 @@ static int cmd_reg_handler(struct parser_exec_state *s,
>  		return -EPERM;
>  	}
>  
> +	if (!strncmp(cmd, "pipe_ctrl", 9)) {
> +		//TODO

Let's write more on what should be for TODO and use proper comment
style /* ... */. So for pipe_ctrl, only thing to care in this case is
LRI post operation, which is just like another LRI cmd, so should be
applied with same check as in the last patch of this series.

It'll be ideal if we can add this before merging the series, hopefully
not much for extra effort.

> +		return 0;
> +	}
> +
>  	if (is_cmd_update_pdps(offset, s) &&
>  	    cmd_pdp_mmio_update_handler(s, offset, index))
>  		return -EINVAL;
> -- 
> 2.17.1
> 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev

-- 

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20201201/662b80fc/attachment.sig>