[PATCH 1/3] drm/i915/gvt: cleanup debugfs scan_nonprivbb

[Zhenyu Wang]

As no regression found for this series, I'll merge them.

Acked-by: Zhenyu Wang <zhenyuw at linux.intel.com>

On 2020.03.04 11:23:05 +0800, Zhenyu Wang wrote:
> From: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Remove extra chatty message for debugfs scan_nonprivbb which is used
> to enable scan for non privileged batch on specific engine. Just write
> target i915 engine mask instead.
> 
> Cc: Ding Zhuocheng <zhuocheng.ding at intel.com>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Zhenyu Wang <zhenyuw at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/debugfs.c | 36 +-----------------------------
>  1 file changed, 1 insertion(+), 35 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/debugfs.c b/drivers/gpu/drm/i915/gvt/debugfs.c
> index 285f6011a537..874ee1de6b49 100644
> --- a/drivers/gpu/drm/i915/gvt/debugfs.c
> +++ b/drivers/gpu/drm/i915/gvt/debugfs.c
> @@ -128,6 +128,7 @@ static int
>  vgpu_scan_nonprivbb_get(void *data, u64 *val)
>  {
>  	struct intel_vgpu *vgpu = (struct intel_vgpu *)data;
> +
>  	*val = vgpu->scan_nonprivbb;
>  	return 0;
>  }
> @@ -142,42 +143,7 @@ static int
>  vgpu_scan_nonprivbb_set(void *data, u64 val)
>  {
>  	struct intel_vgpu *vgpu = (struct intel_vgpu *)data;
> -	struct drm_i915_private *dev_priv = vgpu->gvt->dev_priv;
> -	enum intel_engine_id id;
> -	char buf[128], *s;
> -	int len;
> -
> -	val &= (1 << I915_NUM_ENGINES) - 1;
> -
> -	if (vgpu->scan_nonprivbb == val)
> -		return 0;
> -
> -	if (!val)
> -		goto done;
> -
> -	len = sprintf(buf,
> -		"gvt: vgpu %d turns on non-privileged batch buffers scanning on Engines:",
> -		vgpu->id);
> -
> -	s = buf + len;
> -
> -	for (id = 0; id < I915_NUM_ENGINES; id++) {
> -		struct intel_engine_cs *engine;
> -
> -		engine = dev_priv->engine[id];
> -		if (engine && (val & (1 << id))) {
> -			len = snprintf(s, 4, "%d, ", engine->id);
> -			s += len;
> -		} else
> -			val &=  ~(1 << id);
> -	}
> -
> -	if (val)
> -		sprintf(s, "low performance expected.");
> -
> -	pr_warn("%s\n", buf);
>  
> -done:
>  	vgpu->scan_nonprivbb = val;
>  	return 0;
>  }
> -- 
> 2.25.1
> 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20200306/337b45b1/attachment.sig>