[PATCH] drm/i915/gvt: Add some regs to force-to-nonpriv whitelist

[Zhenyu Wang]

On 2020.03.17 17:14:14 +0800, Tina Zhang wrote:
> Those regs are added in order to slove the following complains:
> 
>  [70811.201818] gvt: vgpu(1) Invalid FORCE_NONPRIV write 2341 at offset 24d8
>  [70811.201825] gvt: vgpu(1) Invalid FORCE_NONPRIV write 2351 at offset 24dc
>  [70811.201831] gvt: vgpu(1) Invalid FORCE_NONPRIV write 10000d82 at offset 24e0
>  [70811.201837] gvt: vgpu(1) Invalid FORCE_NONPRIV write 10064844 at offset 24e4
> 
> So solve them by adding the required regs to the whitelist.
> 
> v2: give name to 0x64844 mmio (zhenyu)
> 
> Signed-off-by: Tina Zhang <tina.zhang at intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/handlers.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
> index 0182e2a5acff..35f432e68364 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -462,11 +462,16 @@ static int pipeconf_mmio_write(struct intel_vgpu *vgpu, unsigned int offset,
>  	return 0;
>  }
>  
> -/* ascendingly sorted */
> +#define SRD_PERF_CNT _MMIO(0x64844)
> +
> +/* sorted in ascending order */
>  static i915_reg_t force_nonpriv_white_list[] = {
> +	_MMIO(0xd80),
>  	GEN9_CS_DEBUG_MODE1, //_MMIO(0x20ec)
>  	GEN9_CTX_PREEMPT_REG,//_MMIO(0x2248)
> -	PS_INVOCATION_COUNT,//_MMIO(0x2348)
> +	CL_PRIMITIVES_COUNT, //_MMIO(0x2340)
> +	PS_INVOCATION_COUNT, //_MMIO(0x2348)
> +	PS_DEPTH_COUNT, //_MMIO(0x2350)
>  	GEN8_CS_CHICKEN1,//_MMIO(0x2580)
>  	_MMIO(0x2690),
>  	_MMIO(0x2694),
> @@ -491,6 +496,7 @@ static i915_reg_t force_nonpriv_white_list[] = {
>  	_MMIO(0xe18c),
>  	_MMIO(0xe48c),
>  	_MMIO(0xe5f4),
> +	SRD_PERF_CNT, //_MMIO(0x64844),
>  };

oh, I just picked original version, if i915 hasn't defined that,
better can add in i915_reg.h, otherwise can live with the reg value.

>  
>  /* a simple bsearch */
> -- 
> 2.17.1
> 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20200317/1a3b017c/attachment.sig>