[PATCH] drm/i915/gvt: do not check len & max_len for lri

[Zhenyu Wang]

On 2020.03.04 04:51:21 -0500, Yan Zhao wrote:
> lri ususally of variable len and far exceeding 127 dwords.
> 
> Fixes: 00a33be40634 (drm/i915/gvt: Add valid length check for MI variable
> commands)
> 
> Signed-off-by: Yan Zhao <yan.y.zhao at intel.com>

Ack for this fix which seems true in practical, suppose our ring shadow already
has sane range check.

Acked-by: Zhenyu Wang <zhenyuw at linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gvt/cmd_parser.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index 73a2891114a4..151fea215e5c 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -965,18 +965,6 @@ static int cmd_handler_lri(struct parser_exec_state *s)
>  	int i, ret = 0;
>  	int cmd_len = cmd_length(s);
>  	struct intel_gvt *gvt = s->vgpu->gvt;
> -	u32 valid_len = CMD_LEN(1);
> -
> -	/*
> -	 * Official intel docs are somewhat sloppy , check the definition of
> -	 * MI_LOAD_REGISTER_IMM.
> -	 */
> -	#define MAX_VALID_LEN 127
> -	if ((cmd_len < valid_len) || (cmd_len > MAX_VALID_LEN)) {
> -		gvt_err("len is not valid:  len=%u  valid_len=%u\n",
> -			cmd_len, valid_len);
> -		return -EFAULT;
> -	}
>  
>  	for (i = 1; i < cmd_len; i += 2) {
>  		if (IS_BROADWELL(gvt->dev_priv) && s->ring_id != RCS0) {
> -- 
> 2.17.1
> 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20200318/957cbe42/attachment-0001.sig>