[PATCH 2/2] drm/i915/gvt: Remove duplicated register accessible check

Colin Xu colin.xu at intel.com
Thu Apr 15 01:29:20 UTC 2021


On Wed, 14 Apr 2021, Zhenyu Wang wrote:

> Looks this duplication was missed in code rebase. Remove extra check.
>
> Cc: Yan Zhao <yan.y.zhao at intel.com>
> Fixes: 02dd2b12a685 ("drm/i915/gvt: unify lri cmd handler and mmio handlers")
> Signed-off-by: Zhenyu Wang <zhenyuw at linux.intel.com>
> ---
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index 01c1d1b36acd..ca9c9e27a43d 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -948,11 +948,6 @@ static int cmd_reg_handler(struct parser_exec_state *s,
>
> 	/* below are all lri handlers */
> 	vreg = &vgpu_vreg(s->vgpu, offset);
> -	if (!intel_gvt_mmio_is_cmd_accessible(gvt, offset)) {
> -		gvt_vgpu_err("%s access to non-render register (%x)\n",
> -				cmd, offset);
> -		return -EBADRQC;
> -	}
>
> 	if (is_cmd_update_pdps(offset, s) &&
> 	    cmd_pdp_mmio_update_handler(s, offset, index))
> -- 
> 2.31.0
>
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
>

Reviewed-by: Colin Xu <colin.xu at intel.com>



More information about the intel-gvt-dev mailing list