[bug report] i915/gvt: Separate the MMIO tracking table from GVT-g

Dan Carpenter dan.carpenter at oracle.com
Thu Apr 28 12:25:37 UTC 2022


Hello Zhi Wang,

This is a semi-automatic email about new static checker warnings.

The patch e0f74ed4634d: "i915/gvt: Separate the MMIO tracking table 
from GVT-g" from Apr 7, 2022, leads to the following Smatch complaint:

    drivers/gpu/drm/i915/gvt/handlers.c:2924 init_mmio_block_handlers()
    error: we previously assumed 'block' could be null (see line 2923)

drivers/gpu/drm/i915/gvt/handlers.c
  2922		block = find_mmio_block(gvt, VGT_PVINFO_PAGE);
  2923		if (!block) {
                    ^^^^^^
This is NULL

  2924			WARN(1, "fail to assign handlers to mmio block %x\n",
  2925			     i915_mmio_reg_offset(block->offset));
                                                  ^^^^^^^^^^^^^
Crash!

  2926			return -ENODEV;

regards,
dan carpenter


More information about the intel-gvt-dev mailing list