[PATCH 13/13] vfio/mdev: add mdev available instance checking to the core
Tian, Kevin
kevin.tian at intel.com
Tue Jun 14 10:32:11 UTC 2022
> From: Christoph Hellwig
> Sent: Tuesday, June 14, 2022 12:54 PM
>
> From: Jason Gunthorpe <jgg at nvidia.com>
>
> Many of the mdev drivers use a simple counter for keeping track of the
> available instances. Move this code to the core code and store the counter
> in the mdev_type. Implement it using correct locking, fixing mdpy.
>
> Drivers provide a the value in the mdev_driver at registration time and
> the core code provides a standard sysfs attribute to return the
> available_instances.
>
> Signed-off-by: Jason Gunthorpe <jgg at nvidia.com>
> [count instances per-parent instead of per-type]
per-parent counting works only if the parent doesn't have overlapping
instances between types. This is probably worth a clarification in doc.
> @@ -135,6 +136,7 @@ static void mdev_device_release(struct device *dev)
>
> mutex_lock(&mdev_list_lock);
> list_del(&mdev->next);
> + mdev->type->parent->available_instances++;
if (!drv->get_available)
mdev->type->parent->available_instances++;
Otherwise this looks good to me:
Reviewed-by: Kevin Tian <kevin.tian at intel.com>
More information about the intel-gvt-dev
mailing list