[PATCH] drm/i915/gvt: char array initialization overflow

[Murthy, Arun R]

> -----Original Message-----
> From: Andi Shyti <andi.shyti at linux.intel.com>
> Sent: Thursday, March 27, 2025 9:11 PM
> To: Murthy, Arun R <arun.r.murthy at intel.com>
> Cc: intel-gvt-dev at lists.freedesktop.org; andi.shyti at linux.intel.com
> Subject: Re: [PATCH] drm/i915/gvt: char array initialization overflow
> 
> Hi Arun,
> 
> This produces a build error in my configuration, could you please cc also intel-
> gfx so that we run also the CI tests?
> 
> Thanks,
> Andi
> 
Hi Andi,

Thanks for the review. I think this patch can be discarded as a patch was this fix has already been floated https://lore.kernel.org/r/87r02ma8s3.fsf@intel.com

Thanks and Regards,
Arun R Murthy
--------------------

> On Tue, Mar 25, 2025 at 09:16:43AM +0530, Arun R Murthy wrote:
> > Initializer string for array of char is too long, since the char array
> > is initialized in place leave the length as open and let compiler
> > choose based on the initialized value.
> >
> > Signed-off-by: Arun R Murthy <arun.r.murthy at intel.com>
> > ---
> >  drivers/gpu/drm/i915/gvt/opregion.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/opregion.c
> > b/drivers/gpu/drm/i915/gvt/opregion.c
> > index
> >
> 509f9ccae3a9f09a7596904d88a3ac15cf6b1be7..c5ea490bf2e184c4184e16197
> 367
> > 5a38436e078c 100644
> > --- a/drivers/gpu/drm/i915/gvt/opregion.c
> > +++ b/drivers/gpu/drm/i915/gvt/opregion.c
> > @@ -222,7 +222,7 @@ int intel_vgpu_init_opregion(struct intel_vgpu *vgpu)
> >  	u8 *buf;
> >  	struct opregion_header *header;
> >  	struct vbt v;
> > -	const char opregion_signature[16] = OPREGION_SIGNATURE;
> > +	const char opregion_signature[] = OPREGION_SIGNATURE;
> >
> >  	gvt_dbg_core("init vgpu%d opregion\n", vgpu->id);
> >  	vgpu_opregion(vgpu)->va = (void *)__get_free_pages(GFP_KERNEL |
> >
> > ---
> > base-commit: 9a42bdcde0f77b2c1e947e283cc3b267b1ce2056
> > change-id: 20250325-gvt-4e9f71337d3f
> >
> > Best regards,
> > --
> > Arun R Murthy <arun.r.murthy at intel.com>