<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-2022-jp">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"MS PGothic";
panose-1:2 11 6 0 7 2 5 8 2 4;}
@font-face
{font-family:"\@MS PGothic";
panose-1:2 11 6 0 7 2 5 8 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:JA;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
mso-fareast-language:JA;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
mso-fareast-language:JA;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi Wang, Zhi A<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks for your kindly remind, modified in E-mail history,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">---<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Zhou, Wenjia<o:p></o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Wang, Zhi A [mailto:zhi.a.wang@intel.com]
<br>
<b>Sent:</b> Tuesday, July 04, 2017 11:08 AM<br>
<b>To:</b> Zhiyuan Zhu(</span><span lang="JA" style="font-size:10.0pt;font-family:"MS PGothic","sans-serif"">$B<k;V1s(B</span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">); zhenyuw@linux.intel.com; Zheng, Xiao; He, Min; Niu, Bing<br>
<b>Cc:</b> intel-gvt-dev@lists.freedesktop.org; Zijun Hu(</span><span lang="JA" style="font-size:10.0pt;font-family:"MS PGothic","sans-serif"">$B8U<+73(B</span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">)<br>
<b>Subject:</b> RE: [PATCH] drivers/gpu/drm/i915/gvt/gtt.c: fix memory leak<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-CN">Hi Zhenjia:<o:p></o:p></span></p>
<p class="MsoNormal" style="text-indent:10.0pt"><span style="color:#1F497D;mso-fareast-language:ZH-CN">Thanks for the contribution. You can change your name to $B!H(BWenjia Zhou$B!I(B or $B!H(BZhou, Wenjia$B!I(B in git username.<o:p></o:p></span></p>
<p class="MsoNormal" style="text-indent:10.0pt"><span style="color:#1F497D;mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal" style="text-indent:10.0pt"><span style="color:#1F497D;mso-fareast-language:ZH-CN">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal" style="text-indent:10.0pt"><span style="color:#1F497D;mso-fareast-language:ZH-CN">Zhi.<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"></a><span style="color:#1F497D;mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> <a href="mailto:zhiyuan_zhu@htc.com">zhiyuan_zhu@htc.com</a> [<a href="mailto:zhiyuan_zhu@htc.com">mailto:zhiyuan_zhu@htc.com</a>]
<br>
<b>Sent:</b> Tuesday, July 4, 2017 6:01 AM<br>
<b>To:</b> Wang, Zhi A <<a href="mailto:zhi.a.wang@intel.com">zhi.a.wang@intel.com</a>>;
<a href="mailto:zhenyuw@linux.intel.com">zhenyuw@linux.intel.com</a>; Zheng, Xiao <<a href="mailto:xiao.zheng@intel.com">xiao.zheng@intel.com</a>>; He, Min <<a href="mailto:min.he@intel.com">min.he@intel.com</a>>; Niu, Bing <<a href="mailto:bing.niu@intel.com">bing.niu@intel.com</a>><br>
<b>Cc:</b> <a href="mailto:intel-gvt-dev@lists.freedesktop.org">intel-gvt-dev@lists.freedesktop.org</a>;
<a href="mailto:zijun_hu@htc.com">zijun_hu@htc.com</a><br>
<b>Subject:</b> [PATCH] drivers/gpu/drm/i915/gvt/gtt.c: fix memory leak<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">From: </span><span style="color:#1F497D">Zhou, Wenjia</span><span style="color:#1F497D"> <<a href="mailto:zhiyuan_zhu@htc.com">zhiyuan_zhu@htc.com</a>><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">It will causes memory leak, if the function setup_spt_oos fail,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">in the function intel_gvt_init_gtt,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">which allocated by get_zeroed_page and mapped by dma_map_page.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">After STP oos initialize fail, unmap and free the page,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">It will fix this issue.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Signed-off-by: </span><span style="color:#1F497D">Zhou, Wenjia</span><span style="color:#1F497D"> <<a href="mailto:zhiyuan_zhu@htc.com">zhiyuan_zhu@htc.com</a>><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">---<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">drivers/gpu/drm/i915/gvt/gtt.c | 2 ++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">1 file changed, 2 insertions(+)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">index c6f0077..f2b352b 100644<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">--- a/drivers/gpu/drm/i915/gvt/gtt.c<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">+++ b/drivers/gpu/drm/i915/gvt/gtt.c<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">@@ -2254,6 +2254,8 @@ int intel_gvt_init_gtt(struct intel_gvt *gvt)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> ret = setup_spt_oos(gvt);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> if (ret) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> gvt_err("fail to initialize SPT oos\n");<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">+ dma_unmap_page(dev, daddr, 4096, PCI_DMA_BIDIRECTIONAL);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">+ __free_page(gvt->gtt.scratch_ggtt_page);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> return ret;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">---<o:p></o:p></span></p>
</div>
</body>
</html>