[Intel-xe] [PATCH v2 2/8] drm/xe/irq: Add helpers to find ISR/IIR/IMR/IER registers

Lucas De Marchi lucas.demarchi at intel.com
Sat Apr 1 00:37:46 UTC 2023


On Fri, Mar 31, 2023 at 05:21:00PM -0700, Matt Roper wrote:
>For cases where IRQ_INIT and IRQ_RESET are used, the relevant interrupt
>registers are always consecutive and ordered ISR, IMR, IIR, IER.  Adding
>helpers to look these up from a base offset will let us eliminate some
>of the CPP pasting and simplify other upcoming patches.
>
>v2:
> - s/_REGS/_OFFSET/ for consistency.  (Lucas)
> - Move IMR/IIR/IER helpers into xe_irq.c; they aren't needed anywhere
>   else.  (Lucas)
>
>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>Signed-off-by: Matt Roper <matthew.d.roper at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi


More information about the Intel-xe mailing list