[Intel-xe] [PATCH 4/6] drm/xe: Fix XE_LPDP and meteorlake display info.

[Lucas De Marchi]

On Fri, Mar 31, 2023 at 12:24:17PM +0200, Maarten Lankhorst wrote:
>MTL has modular FIA, and LPDP also has FBC on pipe B.

commit message needs to be drm/xe/display: Fix XE_LPDP and meteorlake

And here:

Bspec: 65380
>
>Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>---
> drivers/gpu/drm/xe/xe_display.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_display.c b/drivers/gpu/drm/xe/xe_display.c
>index e9b3997c4028..64e65b29d8de 100644
>--- a/drivers/gpu/drm/xe/xe_display.c
>+++ b/drivers/gpu/drm/xe/xe_display.c
>@@ -475,8 +475,8 @@ __diag_ignore_all("-Woverride-init", "Allow field overrides in table");
> 	XE_LPD,								\
> 	.ver = 14,							\
> 	.has_cdclk_crawl = 1,						\
>-	.has_cdclk_squash = 1
>-
>+	.has_cdclk_squash = 1,						\
>+	.fbc_mask = BIT(INTEL_FBC_A) | BIT(INTEL_FBC_B)
>
> void xe_display_info_init(struct xe_device *xe)
> {
>@@ -513,7 +513,10 @@ void xe_display_info_init(struct xe_device *xe)
> 		};
> 		break;
> 	case XE_METEORLAKE:
>-		xe->info.display = (struct xe_device_display_info) { XE_LPDP };
>+		xe->info.display = (struct xe_device_display_info) {
>+			XE_LPDP,
>+			.has_modular_fia = 1,

I think to avoid the extra 3-level inheritance here and based on BSpec 65380,
it's safe to just add this to LPDP.

+Matt Roper on that.

With those changes, feel free to add:

	Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

thanks
Lucas De Marchi

>+		};
> 		break;
> 	default:
> 		drm_dbg(&xe->drm, "No display IP, skipping\n");
>-- 
>2.34.1
>