[Intel-xe] [PATCH 0/2] drm/xe: Revert coalescing of GGTT invalidations

Lucas De Marchi lucas.demarchi at intel.com
Thu Apr 6 21:28:01 UTC 2023


On Thu, Apr 06, 2023 at 01:48:39PM -0700, Niranjana Vishwanathapura wrote:
>Causing a bunch of hangs driver load and in user space.
>https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/232
>
>Benefit is rather small too, so revert it to stablize the stack.

For both patches:

Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

I'm actually expecting these to be "squashed" in the original patch,
i.e. that we will have a rebase removing them from the branch. If that
is not the case, then you need a much better explanation in the commit
itself rather than on the cover letter.

Lucas De Marchi

>
>Reverts below changes
>drm/xe: Pad GGTT mapping with an extra page pointing to scratch
>drm/xe: Coalesce GGTT invalidations
>
>Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
>
>Niranjana Vishwanathapura (2):
>  Revert "drm/xe: Pad GGTT mapping with an extra page pointing to
>    scratch"
>  Revert "drm/xe: Coalesce GGTT invalidations"
>
> drivers/gpu/drm/xe/xe_bo.c         |  1 -
> drivers/gpu/drm/xe/xe_bo.h         |  1 +
> drivers/gpu/drm/xe/xe_bo_types.h   |  4 +---
> drivers/gpu/drm/xe/xe_ggtt.c       | 35 +++++++-----------------------
> drivers/gpu/drm/xe/xe_ggtt_types.h |  2 --
> 5 files changed, 10 insertions(+), 33 deletions(-)
>
>-- 
>2.21.0.rc0.32.g243a4c7e27
>


More information about the Intel-xe mailing list