[Intel-xe] [PATCH v2 rebased 4/6] drm/xe/display: Enable modular fia in TGL

Souza, Jose jose.souza at intel.com
Mon Apr 10 16:24:09 UTC 2023


On Mon, 2023-04-10 at 11:38 -0400, Rodrigo Vivi wrote:
> On Thu, Apr 06, 2023 at 07:31:31AM -0700, José Roberto de Souza wrote:
> > TGL is the first platform tha has it.
> > Enabling it for DG1 don't cause any issues as DG1 don't have any real
> > TC ports, so intel_tc_port_init() will not be called for DG1.
> 
> so, why do we need to enable then?

TGL had it disabled.
This is needed to properly initialize TC in some skus.

> 
> > 
> > Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_display.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_display.c b/drivers/gpu/drm/xe/xe_display.c
> > index 5fab5b9fbde0c..0001a9d02495d 100644
> > --- a/drivers/gpu/drm/xe/xe_display.c
> > +++ b/drivers/gpu/drm/xe/xe_display.c
> > @@ -486,7 +486,10 @@ void xe_display_info_init(struct xe_device *xe)
> >  	switch (xe->info.platform) {
> >  	case XE_TIGERLAKE:
> >  	case XE_DG1:
> > -		xe->info.display = (struct xe_device_display_info) { GEN12_DISPLAY };
> > +		xe->info.display = (struct xe_device_display_info) {
> > +			GEN12_DISPLAY,
> > +			.has_modular_fia = 1,
> > +		};
> >  		break;
> >  	case XE_ALDERLAKE_S:
> >  		xe->info.display = (struct xe_device_display_info) {
> > -- 
> > 2.40.0
> > 



More information about the Intel-xe mailing list