[Intel-xe] [PATCH 3/3] drm/xe: Only request PCODE_WRITE_MIN_FREQ_TABLE on LLC platforms

Lucas De Marchi lucas.demarchi at intel.com
Tue Apr 11 07:01:15 UTC 2023


On Mon, Apr 10, 2023 at 11:39:10AM -0700, Matt Roper wrote:
>PCODE_WRITE_MIN_FREQ_TABLE is only applicable to platforms with an LLC.
>Change the discrete GPU check to an LLC check instead; this take care of
>skipping not only the discrete platforms, but also integrated platforms
>like MTL that do not have an LLC.
>
>Fixes MTL dmesg error:
>
>  xe 0000:00:02.0: [drm] *ERROR* PCODE Mailbox failed: 1 Illegal Command
>
>Signed-off-by: Matt Roper <matthew.d.roper at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_pcode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
>index fb1ce2d49bec..99bb730684ed 100644
>--- a/drivers/gpu/drm/xe/xe_pcode.c
>+++ b/drivers/gpu/drm/xe/xe_pcode.c
>@@ -210,7 +210,7 @@ int xe_pcode_init_min_freq_table(struct xe_gt *gt, u32 min_gt_freq,
> 	int ret;
> 	u32 freq;
>
>-	if (IS_DGFX(gt_to_xe(gt)))
>+	if (!gt_to_xe(gt)->info.has_llc)
> 		return 0;
>
> 	if (max_gt_freq <= min_gt_freq)
>-- 
>2.39.2
>


More information about the Intel-xe mailing list