[Intel-xe] [Intel-gfx] [PATCH v3 1/6] drm/i915: Initialize dkl_phy spin lock from display code path

[Ville Syrjälä]

On Tue, Apr 11, 2023 at 11:51:33AM +0300, Jani Nikula wrote:
> On Tue, 11 Apr 2023, Ville Syrjälä <ville.syrjala at linux.intel.com> wrote:
> > On Mon, Apr 10, 2023 at 11:32:14AM -0700, José Roberto de Souza wrote:
> >> Start to move the initialization of some lock from
> >> i915_driver_early_probe().
> >> No dkl function is called prior to intel_setup_outputs(), so this is
> >> a good place to initialize it.
> >
> > I disagree. We don't want to sprinke these all over the place.
> 
> I'm thinking if only foo.c uses a lock, foo.c should initialize it, not
> someone else.

Perhaps. But I think there should be some consistent place in the higher
level code where all such things get called instead of dropping each one
individually into some random spot in the overlall display init flow.

-- 
Ville Syrjälä
Intel