[Intel-xe] [PATCH] drm/xe: Add missing spin_lock_inits for display

Lucas De Marchi lucas.demarchi at intel.com
Fri Apr 14 17:49:55 UTC 2023


On Fri, Apr 14, 2023 at 05:00:25PM +0200, Maarten Lankhorst wrote:
>We have gained 2 locks, better init those.

should be a fixup to the original commit adding display. When we rebase
we will have conflicts since the locks were moved around, but I don't
think we have much option other than fixing the conflicts when they
happen. It's a downside of the rebasing branch.

Ideally in the final state when the i915 side of the refactors is
completed, we will just not have to init any lock here as it would be
as part of the display init on the i915 side.

Lucas De Marchi

>
>Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>---
> drivers/gpu/drm/xe/xe_display.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/xe_display.c b/drivers/gpu/drm/xe/xe_display.c
>index aae362f27c77..719a64005e29 100644
>--- a/drivers/gpu/drm/xe/xe_display.c
>+++ b/drivers/gpu/drm/xe/xe_display.c
>@@ -91,6 +91,8 @@ int xe_display_create(struct xe_device *xe)
> 	int err;
>
> 	spin_lock_init(&xe->display.fb_tracking.lock);
>+	spin_lock_init(&xe->display.dkl.phy_lock);
>+	spin_lock_init(&xe->display.wm.dsparb_lock);
>
> 	xe->display.hotplug.dp_wq = alloc_ordered_workqueue("xe-dp", 0);
>
>-- 
>2.34.1
>


More information about the Intel-xe mailing list