[Intel-xe] [PATCH v2 3/8] drm/xe/irq: Process Gunit interrupts in relation to the device

Lucas De Marchi lucas.demarchi at intel.com
Fri Apr 14 19:59:09 UTC 2023


On Wed, Apr 12, 2023 at 03:52:43PM -0700, Matt Roper wrote:
>The only Gunit interrupts we handle today are GSE ASLE interrupts, which
>are an old opregion way of doing display backlight notifications.  These
>aren't related to GT at all, and if/when we have a multi-tile platform
>with display in the future, we'll expect such ASLE interrupts to always
>be delivered on the primary tile, the same as other display interrupts.
>
>dg1_irq_handler() is currently passing whatever GT was processed last as
>a parameter to gu_misc_irq_ack(), which isn't what we want.  Switch
>gu_misc_irq_ack() to just take a drm_xe_device as a parameter so that
>its handling isn't tied to the previous GT processing loop and there's
>no ambiguity about what it's doing.

why don't we move it to be inside xe_display_irq_handler()? If we don't
have XE_DISPLAY enabled it doesn't seem like we want to do anything
here.

>
>Signed-off-by: Matt Roper <matthew.d.roper at intel.com>


Anyway, change here also makes sense by itself


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi


More information about the Intel-xe mailing list