[Intel-xe] [PATCH 2/2] drm/xe: Change log level of error prints

Matthew Auld matthew.william.auld at gmail.com
Fri Apr 21 16:43:05 UTC 2023


On Fri, 21 Apr 2023 at 16:39, Balasubramani Vivekanandan
<balasubramani.vivekanandan at intel.com> wrote:
>
> Error prints are logged using drm_err log level.
>
> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_mmio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
> index 8bd39c3e65ae..7a0fcb37aab0 100644
> --- a/drivers/gpu/drm/xe/xe_mmio.c
> +++ b/drivers/gpu/drm/xe/xe_mmio.c
> @@ -59,8 +59,8 @@ _resize_bar(struct xe_device *xe, int resno, resource_size_t size)
>
>         ret = pci_resize_resource(pdev, resno, bar_size);
>         if (ret) {
> -               drm_info(&xe->drm, "Failed to resize BAR%d to %dM (%pe)\n",
> -                        resno, 1 << bar_size, ERR_PTR(ret));
> +               drm_err(&xe->drm, "Failed to resize BAR%d to %dM (%pe)\n",
> +                       resno, 1 << bar_size, ERR_PTR(ret));

Not sure if we should treat it as an error, also there might be
nothing the user can really do. The driver should still be functional.

>                 return -1;
>         }
>
> @@ -119,7 +119,7 @@ static int xe_resize_vram_bar(struct xe_device *xe, resource_size_t vram_size)
>         }
>
>         if (!root_res) {
> -               drm_info(&xe->drm, "Can't resize VRAM BAR - platform support is missing. Consider enabling 'Resizable BAR' support in your BIOS\n");
> +               drm_err(&xe->drm, "Can't resize VRAM BAR - platform support is missing. Consider enabling 'Resizable BAR' support in your BIOS\n");

Same here.

>                 return -1;
>         }
>
> --
> 2.34.1
>


More information about the Intel-xe mailing list