[Intel-xe] [PATCH] drm/xe: Remove extra xe_mmio_read32 from xe_mmio_wait32

Mika Kuoppala mika.kuoppala at linux.intel.com
Thu Apr 27 12:53:25 UTC 2023


Maarten Lankhorst <maarten.lankhorst at linux.intel.com> writes:

> Commit 5a2be6ba6ba0 ("drm/xe: Let's return last value read on
> xe_mmio_wait32.") mentions that we should return the last value read,
> but we never actually return it. This breaks display which depends on
> the value being actually returned where needed.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Fixes: 5a2be6ba6ba0 ("drm/xe: Let's return last value read on xe_mmio_wait32.")

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

> ---
>  drivers/gpu/drm/xe/xe_mmio.h | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_mmio.h b/drivers/gpu/drm/xe/xe_mmio.h
> index a36c52bc098b..1a32e0f52261 100644
> --- a/drivers/gpu/drm/xe/xe_mmio.h
> +++ b/drivers/gpu/drm/xe/xe_mmio.h
> @@ -85,9 +85,6 @@ static inline int xe_mmio_wait32(struct xe_gt *gt, u32 reg, u32 val, u32 mask,
>  	u32 read;
>  
>  	for (;;) {
> -		if ((xe_mmio_read32(gt, reg) & mask) == val)
> -			return 0;
> -
>  		read = xe_mmio_read32(gt, reg);
>  		if ((read & mask) == val) {
>  			ret = 0;
> -- 
> 2.37.2


More information about the Intel-xe mailing list