[Intel-xe] ✗ CI.checkpatch: warning for Rename engine to exec_queue (rev3)

Patchwork patchwork at emeril.freedesktop.org
Tue Aug 1 10:51:49 UTC 2023


== Series Details ==

Series: Rename engine to exec_queue (rev3)
URL   : https://patchwork.freedesktop.org/series/121627/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 088aa4f088f6b0e3d458ad713e922fd35259125a
Author: Francois Dugast <francois.dugast at intel.com>
Date:   Tue Aug 1 10:48:42 2023 +0000

    drm/xe: Rename engine to exec_queue
    
    Engine was inappropriately used to refer to execution queues and it
    also created some confusion with hardware engines. Where it applies
    the exec_queue variable name is changed to q and comments are also
    updated.
    
    Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/162
    Signed-off-by: Francois Dugast <francois.dugast at intel.com>
    Acked-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch d74e8f8407bc922b04ba50e8f4e888bedb31330a drm-intel
416a56898 drm/xe: Rename xe_engine.[ch] to xe_exec_queue.[ch]
-:66: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#66: 
rename from drivers/gpu/drm/xe/xe_engine.c

total: 0 errors, 1 warnings, 0 checks, 114 lines checked
088aa4f08 drm/xe: Rename engine to exec_queue
-:1709: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#1709: 
rename from drivers/gpu/drm/xe/xe_engine_types.h

-:3273: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'q' may be better as '(q)' to avoid precedence issues
#3273: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:694:
+#define MAKE_SCHED_CONTEXT_ACTION(q, enable_disable)			\
 	u32 action[] = {						\
 		XE_GUC_ACTION_SCHED_CONTEXT_MODE_SET,			\
+		q->guc->id,						\
 		GUC_CONTEXT_##enable_disable,				\
 	}

-:6538: WARNING:LONG_LINE: line length of 134 exceeds 100 columns
#6538: FILE: include/uapi/drm/xe_drm.h:122:
+#define DRM_IOCTL_XE_EXEC_QUEUE_CREATE		DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_EXEC_QUEUE_CREATE, struct drm_xe_exec_queue_create)

-:6539: WARNING:LONG_LINE: line length of 146 exceeds 100 columns
#6539: FILE: include/uapi/drm/xe_drm.h:123:
+#define DRM_IOCTL_XE_EXEC_QUEUE_GET_PROPERTY	DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_EXEC_QUEUE_GET_PROPERTY, struct drm_xe_exec_queue_get_property)

-:6540: WARNING:LONG_LINE: line length of 136 exceeds 100 columns
#6540: FILE: include/uapi/drm/xe_drm.h:124:
+#define DRM_IOCTL_XE_EXEC_QUEUE_DESTROY		 DRM_IOW(DRM_COMMAND_BASE + DRM_XE_EXEC_QUEUE_DESTROY, struct drm_xe_exec_queue_destroy)

-:6544: WARNING:LONG_LINE: line length of 146 exceeds 100 columns
#6544: FILE: include/uapi/drm/xe_drm.h:127:
+#define DRM_IOCTL_XE_EXEC_QUEUE_SET_PROPERTY	 DRM_IOW(DRM_COMMAND_BASE + DRM_XE_EXEC_QUEUE_SET_PROPERTY, struct drm_xe_exec_queue_set_property)

total: 0 errors, 5 warnings, 1 checks, 6223 lines checked




More information about the Intel-xe mailing list