[Intel-xe] [PATCH v3 0/2] Rename engine to exec_queue

Rodrigo Vivi rodrigo.vivi at intel.com
Tue Aug 1 10:54:16 UTC 2023


On Tue, Aug 01, 2023 at 10:48:40AM +0000, Francois Dugast wrote:
> This is an attempt to rename engine to exec queue in order to prevent confusion
> between engine and hw engine, as discussed here:
> https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/162
> 
> Looking for feedback on potential mixups between engine and hw engine, either
> because an occurrence of hw engine has incorrectly been renamed to exec queue
> or because an occurrence of engine has not been renamed to exec queue.
> 
> v2:
>   - No longer sent as RFC
>   - Fix kernel doc and some comments
> 
> v3: Rename xe_engine.[ch] in a separate commit to keep history

good idea!

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
for both patches

> 
> Francois Dugast (2):
>   drm/xe: Rename xe_engine.[ch] to xe_exec_queue.[ch]
>   drm/xe: Rename engine to exec_queue
> 
>  drivers/gpu/drm/xe/Makefile                   |    2 +-
>  drivers/gpu/drm/xe/tests/xe_migrate.c         |   18 +-
>  drivers/gpu/drm/xe/xe_bb.c                    |   26 +-
>  drivers/gpu/drm/xe/xe_bb.h                    |    8 +-
>  drivers/gpu/drm/xe/xe_devcoredump.c           |   40 +-
>  drivers/gpu/drm/xe/xe_devcoredump.h           |    6 +-
>  drivers/gpu/drm/xe/xe_devcoredump_types.h     |    2 +-
>  drivers/gpu/drm/xe/xe_device.c                |   62 +-
>  drivers/gpu/drm/xe/xe_device.h                |    8 +-
>  drivers/gpu/drm/xe/xe_device_types.h          |    4 +-
>  drivers/gpu/drm/xe/xe_engine.c                |  850 -------------
>  drivers/gpu/drm/xe/xe_engine.h                |   63 -
>  drivers/gpu/drm/xe/xe_exec.c                  |   62 +-
>  drivers/gpu/drm/xe/xe_exec_queue.c            |  850 +++++++++++++
>  drivers/gpu/drm/xe/xe_exec_queue.h            |   63 +
>  ...e_engine_types.h => xe_exec_queue_types.h} |  110 +-
>  drivers/gpu/drm/xe/xe_execlist.c              |  126 +-
>  drivers/gpu/drm/xe/xe_execlist_types.h        |    8 +-
>  drivers/gpu/drm/xe/xe_gt.c                    |   72 +-
>  drivers/gpu/drm/xe/xe_gt_types.h              |    6 +-
>  drivers/gpu/drm/xe/xe_guc_ads.c               |    2 +-
>  drivers/gpu/drm/xe/xe_guc_ct.c                |   10 +-
>  ...gine_types.h => xe_guc_exec_queue_types.h} |   26 +-
>  drivers/gpu/drm/xe/xe_guc_fwif.h              |    6 +-
>  drivers/gpu/drm/xe/xe_guc_submit.c            | 1076 ++++++++---------
>  drivers/gpu/drm/xe/xe_guc_submit.h            |   20 +-
>  drivers/gpu/drm/xe/xe_guc_submit_types.h      |   20 +-
>  drivers/gpu/drm/xe/xe_guc_types.h             |    4 +-
>  drivers/gpu/drm/xe/xe_lrc.c                   |   10 +-
>  drivers/gpu/drm/xe/xe_lrc.h                   |    4 +-
>  drivers/gpu/drm/xe/xe_migrate.c               |   66 +-
>  drivers/gpu/drm/xe/xe_migrate.h               |    6 +-
>  drivers/gpu/drm/xe/xe_mocs.c                  |    2 +-
>  drivers/gpu/drm/xe/xe_mocs.h                  |    2 +-
>  drivers/gpu/drm/xe/xe_preempt_fence.c         |   32 +-
>  drivers/gpu/drm/xe/xe_preempt_fence.h         |    4 +-
>  drivers/gpu/drm/xe/xe_preempt_fence_types.h   |    7 +-
>  drivers/gpu/drm/xe/xe_pt.c                    |   18 +-
>  drivers/gpu/drm/xe/xe_pt.h                    |    6 +-
>  drivers/gpu/drm/xe/xe_query.c                 |    4 +-
>  drivers/gpu/drm/xe/xe_ring_ops.c              |   38 +-
>  drivers/gpu/drm/xe/xe_sched_job.c             |   76 +-
>  drivers/gpu/drm/xe/xe_sched_job.h             |    4 +-
>  drivers/gpu/drm/xe/xe_sched_job_types.h       |    6 +-
>  drivers/gpu/drm/xe/xe_trace.h                 |  140 +--
>  drivers/gpu/drm/xe/xe_vm.c                    |  178 +--
>  drivers/gpu/drm/xe/xe_vm.h                    |    4 +-
>  drivers/gpu/drm/xe/xe_vm_types.h              |    6 +-
>  include/uapi/drm/xe_drm.h                     |   86 +-
>  49 files changed, 2124 insertions(+), 2125 deletions(-)
>  delete mode 100644 drivers/gpu/drm/xe/xe_engine.c
>  delete mode 100644 drivers/gpu/drm/xe/xe_engine.h
>  create mode 100644 drivers/gpu/drm/xe/xe_exec_queue.c
>  create mode 100644 drivers/gpu/drm/xe/xe_exec_queue.h
>  rename drivers/gpu/drm/xe/{xe_engine_types.h => xe_exec_queue_types.h} (52%)
>  rename drivers/gpu/drm/xe/{xe_guc_engine_types.h => xe_guc_exec_queue_types.h} (59%)
> 
> -- 
> 2.34.1
> 


More information about the Intel-xe mailing list