[Intel-xe] ✗ CI.checkpatch: warning for drm/xe/vm: uncombine the combined_links.destroy
Patchwork
patchwork at emeril.freedesktop.org
Mon Aug 7 13:04:48 UTC 2023
== Series Details ==
Series: drm/xe/vm: uncombine the combined_links.destroy
URL : https://patchwork.freedesktop.org/series/122102/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
e700ea2f248a75138759bcb443affeef4a2d1991
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 5ad0a1d1f734ef4b11363fd5a36dbe6ad6619483
Author: Matthew Auld <matthew.auld at intel.com>
Date: Mon Aug 7 14:02:27 2023 +0100
drm/xe/vm: uncombine the combined_links.destroy
It looks like it's plausible for eviction to be happening as we are
closing the vm, however the rebind_link and destroy links are in this
case not mutually exclusive, since eviction only needs the vm dma-resv
lock which the vm close drops when accessing the contested list. If we
race with eviction here it can run rampant and corrupt the list since
both the destroy and rebind links are the same list entry underneath.
Simplest is to just split these entries into separate links.
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/514
Signed-off-by: Matthew Auld <matthew.auld at intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 8a6b4e2f061b33999d3c0bcaa42441c082103d1e drm-intel
/mt/dim: line 50: /root/.dimrc: No such file or directory
More information about the Intel-xe
mailing list