[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Introduce xe_ASSERT macros (rev2)

[Patchwork]

== Series Details ==

Series: drm/xe: Introduce xe_ASSERT macros (rev2)
URL   : https://patchwork.freedesktop.org/series/121549/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
e700ea2f248a75138759bcb443affeef4a2d1991
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 4dd3328f826a15395523c3e9ab1efe089715dad0
Author: Michal Wajdeczko <michal.wajdeczko at intel.com>
Date:   Mon Aug 7 19:34:46 2023 +0200

    drm/xe: Introduce xe_ASSERT macros
    
    As we are moving away from the controversial XE_BUG_ON macro,
    relying just on WARN_ON or drm_err does not cover the cases
    where we want to annotate functions with additional detailed
    debug checks to assert that all prerequisites are satisfied,
    without paying footprint or performance penalty on non-debug
    builds, where all misuses introduced during code integration
    were already fixed.
    
    Introduce family of xe_ASSERT macros that try to follow classic
    assert() utility and can be compiled out on non-debug builds.
    
    Macros are based on drm_WARN, but unlikely to origin, disallow
    use in expressions since we will compile that code out.
    
    As we are operating on the xe pointers, we can print additional
    information about the device, like tile or GT identifier, that
    is not available from generic WARN report:
    
    [ ] xe 0000:00:02.0: [drm] Assertion `true == false` failed!
        platform: 1 subplatform: 1
        graphics: Xe_LP 12.0 step B0
        media: Xe_M 12.0 step B0
        display: enabled step D0
        tile: 0 VRAM 0 B
        GT: 0 type 1
    
    [ ] xe 0000:b3:00.0: [drm] Assertion `true == false` failed!
        platform: 7 subplatform: 3
        graphics: Xe_HPG 12.55 step A1
        media: Xe_HPM 12.55 step A1
        display: disabled step **
        tile: 0 VRAM 14.0 GiB
        GT: 0 type 1
    
    [ ] WARNING: CPU: 0 PID: 2687 at drivers/gpu/drm/xe/xe_device.c:281 xe_device_probe+0x374/0x520 [xe]
    [ ] RIP: 0010:xe_device_probe+0x374/0x520 [xe]
    [ ] Call Trace:
    [ ]  ? __warn+0x7b/0x160
    [ ]  ? xe_device_probe+0x374/0x520 [xe]
    [ ]  ? report_bug+0x1c3/0x1d0
    [ ]  ? handle_bug+0x42/0x70
    [ ]  ? exc_invalid_op+0x14/0x70
    [ ]  ? asm_exc_invalid_op+0x16/0x20
    [ ]  ? xe_device_probe+0x374/0x520 [xe]
    [ ]  ? xe_device_probe+0x374/0x520 [xe]
    [ ]  xe_pci_probe+0x6e3/0x950 [xe]
    [ ]  ? lockdep_hardirqs_on+0xc7/0x140
    [ ]  pci_device_probe+0x9e/0x160
    [ ]  really_probe+0x19d/0x400
    
    Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
    Cc: Oded Gabbay <ogabbay at kernel.org>
    Cc: Jani Nikula <jani.nikula at intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch efc88276fbeb33df642e51f8f6af395c3e11f181 drm-intel
/mt/dim: line 50: /root/.dimrc: No such file or directory