[Intel-xe] ✗ CI.checkpatch: warning for drm/xe/guc_submit: fixup deregister in job timeout (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Wed Aug 9 08:42:30 UTC 2023
== Series Details ==
Series: drm/xe/guc_submit: fixup deregister in job timeout (rev2)
URL : https://patchwork.freedesktop.org/series/122147/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
e700ea2f248a75138759bcb443affeef4a2d1991
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 61ee49efc24fe258c763819404b9f2d45a2ff958
Author: Matthew Auld <matthew.auld at intel.com>
Date: Wed Aug 9 09:16:18 2023 +0100
drm/xe/guc_submit: fixup deregister in job timeout
Rather check if the engine is still registered before proceeding with
deregister steps. Also the engine being marked as disabled doesn't mean
the engine has been disabled or deregistered from GuC pov, and here we
are signalling fences so we need to be sure GuC is not still using this
context.
v2:
- Drop the read_stopped() for this path. Since we are signalling
fences on error here, best play it safe and wait for the GT reset to
mark the engine as disabled, rather than it just being queued.
v3 (Matt Brost):
- Keep the read_stopped() on the wait event, since there is no need to
wait for an already scheduled GT reset. If it is set we can then just
bail without signalling anything.
Signed-off-by: Matthew Auld <matthew.auld at intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 2ef5b2cdba32ac15df104b1a7f0464df8839f7b0 drm-intel
/mt/dim: line 50: /root/.dimrc: No such file or directory
More information about the Intel-xe
mailing list