[Intel-xe] [PATCH 1/2] fixup! drm/i915/display: Remaining changes to make xe compile
Maarten Lankhorst
dev at lankhorst.se
Mon Aug 14 08:37:43 UTC 2023
From: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_atomic_plane.c | 4 ----
drivers/gpu/drm/i915/display/intel_display_types.h | 7 -------
drivers/gpu/drm/i915/display/intel_dpt.c | 14 +++++---------
drivers/gpu/drm/i915/display/intel_fb.c | 8 ++++----
drivers/gpu/drm/i915/display/skl_universal_plane.c | 6 +-----
drivers/gpu/drm/xe/Makefile | 1 -
6 files changed, 10 insertions(+), 30 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
index edee71664332..1ec7ac74387d 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
@@ -109,9 +109,7 @@ intel_plane_duplicate_state(struct drm_plane *plane)
__drm_atomic_helper_plane_duplicate_state(plane, &intel_state->uapi);
intel_state->ggtt_vma = NULL;
-#ifdef I915
intel_state->dpt_vma = NULL;
-#endif
intel_state->flags = 0;
/* add reference to fb */
@@ -136,9 +134,7 @@ intel_plane_destroy_state(struct drm_plane *plane,
struct intel_plane_state *plane_state = to_intel_plane_state(state);
drm_WARN_ON(plane->dev, plane_state->ggtt_vma);
-#ifdef I915
drm_WARN_ON(plane->dev, plane_state->dpt_vma);
-#endif
__drm_atomic_helper_plane_destroy_state(&plane_state->uapi);
if (plane_state->hw.fb)
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 9310f8f2d940..b46fa3fe8fb0 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -46,7 +46,6 @@
#include <drm/i915_hdcp_interface.h>
#include <media/cec-notifier.h>
-#include "i915_utils.h"
#include "i915_vma.h"
#include "i915_vma_types.h"
#include "intel_bios.h"
@@ -144,9 +143,7 @@ struct intel_framebuffer {
struct intel_fb_view remapped_view;
};
-#ifdef I915
struct i915_address_space *dpt_vm;
-#endif
};
enum intel_hotplug_state {
@@ -701,11 +698,7 @@ struct intel_plane_state {
} hw;
struct i915_vma *ggtt_vma;
-#ifdef I915
struct i915_vma *dpt_vma;
-#else
- struct i915_vma embed_vma;
-#endif
unsigned long flags;
#define PLANE_HAS_FENCE BIT(0)
diff --git a/drivers/gpu/drm/i915/display/intel_dpt.c b/drivers/gpu/drm/i915/display/intel_dpt.c
index 91fcc7a4a331..7c5fddb203ba 100644
--- a/drivers/gpu/drm/i915/display/intel_dpt.c
+++ b/drivers/gpu/drm/i915/display/intel_dpt.c
@@ -3,6 +3,11 @@
* Copyright © 2021 Intel Corporation
*/
+#include "gem/i915_gem_domain.h"
+#include "gem/i915_gem_internal.h"
+#include "gem/i915_gem_lmem.h"
+#include "gt/gen8_ppgtt.h"
+
#include "i915_drv.h"
#include "i915_reg.h"
#include "intel_de.h"
@@ -10,13 +15,6 @@
#include "intel_dpt.h"
#include "intel_fb.h"
-#ifdef I915
-
-#include "gem/i915_gem_domain.h"
-#include "gem/i915_gem_internal.h"
-#include "gem/i915_gem_lmem.h"
-#include "gt/gen8_ppgtt.h"
-
struct i915_dpt {
struct i915_address_space vm;
@@ -318,8 +316,6 @@ void intel_dpt_destroy(struct i915_address_space *vm)
i915_vm_put(&dpt->vm);
}
-#endif
-
void intel_dpt_configure(struct intel_crtc *crtc)
{
struct drm_i915_private *i915 = to_i915(crtc->base.dev);
diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index e0bac4cf3f4b..6c2f09365471 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -1883,11 +1883,12 @@ int intel_plane_compute_gtt(struct intel_plane_state *plane_state)
static void intel_user_framebuffer_destroy_vm(struct drm_framebuffer *fb)
{
-#ifdef I915
struct intel_framebuffer *intel_fb = to_intel_framebuffer(fb);
+
if (intel_fb_uses_dpt(fb))
intel_dpt_destroy(intel_fb->dpt_vm);
-#else
+
+#ifndef I915
if (intel_fb_obj(fb)->flags & XE_BO_CREATE_PINNED_BIT) {
struct xe_bo *bo = intel_fb_obj(fb);
@@ -2113,7 +2114,6 @@ int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
if (ret)
goto err;
-#ifdef I915
if (intel_fb_uses_dpt(fb)) {
struct i915_address_space *vm;
@@ -2126,7 +2126,7 @@ int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
intel_fb->dpt_vm = vm;
}
-#else
+#ifndef I915
/* Hold a reference to object while fb is alive */
xe_bo_get(obj);
#endif
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 1064af3c80d8..c28f4198aa15 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -1010,13 +1010,9 @@ static u32 skl_surf_address(const struct intel_plane_state *plane_state,
* The DPT object contains only one vma, so the VMA's offset
* within the DPT is always 0.
*/
- drm_WARN_ON(&i915->drm, offset & 0x1fffff);
-#ifdef I915
drm_WARN_ON(&i915->drm, plane_state->dpt_vma->node.start);
+ drm_WARN_ON(&i915->drm, offset & 0x1fffff);
return offset >> 9;
-#else
- return 0;
-#endif
} else {
drm_WARN_ON(&i915->drm, offset & 0xfff);
return offset;
diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index 4ea9e3150c20..6d9196ab275c 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -192,7 +192,6 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
i915-display/intel_dp_mst.o \
i915-display/intel_dpll.o \
i915-display/intel_dpll_mgr.o \
- i915-display/intel_dpt.o \
i915-display/intel_drrs.o \
i915-display/intel_dsb.o \
i915-display/intel_dsi.o \
--
2.39.2
More information about the Intel-xe
mailing list