[Intel-xe] ✗ CI.checkpatch: warning for drm/xe/uc: rework uC version tracking

Patchwork patchwork at emeril.freedesktop.org
Wed Aug 16 21:57:44 UTC 2023


== Series Details ==

Series: drm/xe/uc: rework uC version tracking
URL   : https://patchwork.freedesktop.org/series/122542/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
e700ea2f248a75138759bcb443affeef4a2d1991
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit f403388e2324eddd9506de94b2347669d7222ca4
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Date:   Wed Aug 16 14:55:15 2023 -0700

    drm/xe/uc: rework uC version tracking
    
    The GSC firmware, support for which is coming soon for Xe, has both a
    release version (updated on every release) and a compatibility version
    (update only on interface changes). The GuC has something similar, with
    a global release version and a submission version (which is also known
    as the VF compatibility version). The main difference is that for the
    GuC we still want to check the driver requirement against the release
    version, while for the GSC we'll need to check against the compatibility
    version.
    Instead of special casing the GSC, this patch proposes a rework of the
    FW logic so that we store both versions at the uc_fw level for all
    binaries and we allow checking against either of the versions. Initially,
    we'll use it to support GSC, but the logic could be re-used to allow VFs
    to check against their expected GuC compatibility version.
    
    RFC note: I've added a couple of the GSC defines to show how this is
    supposed to be different for the GSC, but those are not intended to be
    part of this patch in its final version. I'd like to get some early
    feedback on this before I build the full GSC version checking on top of
    it.
    
    Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
    Cc: John Harrison <John.C.Harrison at Intel.com>
    Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
    Cc: Michał Winiarski <michal.winiarski at intel.com>
    Cc: Zhanjun Dong <zhanjun.dong at intel.com>
+ /mt/dim checkpatch c605cfb9a29a5425541053b45efddbe9751cbad3 drm-intel
/mt/dim: line 50: /root/.dimrc: No such file or directory




More information about the Intel-xe mailing list