[Intel-xe] [PATCH v2 1/3] drm/xe/pvc: Blacklist BCS_SWCTRL register

[Niranjana Vishwanathapura]

On Thu, Aug 17, 2023 at 09:16:28AM -0700, Matt Roper wrote:
>On Thu, Aug 17, 2023 at 04:03:50AM -0700, Niranjana Vishwanathapura wrote:
>> Wa_16017236439 requires the BCS_SWCTRL to be privileged.
>>
>> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_reg_whitelist.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_reg_whitelist.c b/drivers/gpu/drm/xe/xe_reg_whitelist.c
>> index e83781f9a516..94a2228bf873 100644
>> --- a/drivers/gpu/drm/xe/xe_reg_whitelist.c
>> +++ b/drivers/gpu/drm/xe/xe_reg_whitelist.c
>> @@ -50,6 +50,12 @@ static const struct xe_rtp_entry_sr register_whitelist[] = {
>>  				   RING_FORCE_TO_NONPRIV_DENY |
>>  				   RING_FORCE_TO_NONPRIV_RANGE_64))
>>  	},
>> +	{ XE_RTP_NAME("16017236439"),
>> +	  XE_RTP_RULES(PLATFORM(PVC), ENGINE_CLASS(COPY)),
>> +	  XE_RTP_ACTIONS(WHITELIST(XE_REG(0x200),
>
>Rather than open-coding the XE_REG here, I'd put a definition for
>BCS_SWCTRL in regs/xe_engine_regs.h, and then use it here, similar to
>what we do with the RING_CTX_TIMESTAMP whitelist.
>

Thanks Matt for the review.
Ok, the next patch in the series has it. I will move it here (and rename
it to BCS_SWCTRL)

Niranjana

>
>Matt
>
>> +				   RING_FORCE_TO_NONPRIV_DENY,
>> +				   XE_RTP_ACTION_FLAG(ENGINE_BASE)))
>> +	},
>>  	{}
>>  };
>>
>> --
>> 2.21.0.rc0.32.g243a4c7e27
>>
>
>-- 
>Matt Roper
>Graphics Software Engineer
>Linux GPU Platform Enablement
>Intel Corporation