[Intel-xe] [PATCH v2 2/6] drm/xe/hwmon: Expose power attributes

Andi Shyti andi.shyti at linux.intel.com
Fri Aug 18 13:55:27 UTC 2023


Hi Ashutosh,

> > >
> > > Also the the loop which acquires hwmon->hwmon_lock is confusing too.
> 
> Confusing but correct.

Confusing is implicitely not correct.

Might be correct now, but in some moenths someone else might miss
the point because it's confusing, mis-interpret and send the
wrong code.

Reviewers, going through the +/- commit will have a tough time
figuring out.

Let's keep things easy and simple... there are easier paths for
locking here and we've been discussing them with Badal.

Andi


More information about the Intel-xe mailing list