[Intel-xe] [PATCH] drm/xe: madvise_funcs should use value not property

Matthew Brost matthew.brost at intel.com
Fri Aug 18 14:03:45 UTC 2023


On Fri, Aug 18, 2023 at 07:28:10PM +0530, Tejas Upadhyay wrote:

You need a comment in the commit message.

> Fixes: c160a11ccbef ("drm/xe: Introduce a new DRM driver for Intel GPUs")
>

Delete this newline.

> Cc: Matthew Brost <matthew.brost at intel.com>

With a fixed commit message:
Reviewed-by: Matthew Brost <matthew.brost at intel.com>

> Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_vm_madvise.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm_madvise.c b/drivers/gpu/drm/xe/xe_vm_madvise.c
> index b4e661576d08..c9bc59be5094 100644
> --- a/drivers/gpu/drm/xe/xe_vm_madvise.c
> +++ b/drivers/gpu/drm/xe/xe_vm_madvise.c
> @@ -294,7 +294,7 @@ int xe_vm_madvise_ioctl(struct drm_device *dev, void *data,
>  	}
>  
>  	idx = array_index_nospec(args->property, ARRAY_SIZE(madvise_funcs));
> -	err = madvise_funcs[idx](xe, vm, vmas, num_vmas, args->property);
> +	err = madvise_funcs[idx](xe, vm, vmas, num_vmas, args->value);
>  
>  unlock_vm:
>  	up_read(&vm->lock);
> -- 
> 2.25.1
> 


More information about the Intel-xe mailing list